Re: tlug: bug in xlock

[Scott Stone <sstone@example.com>]

On Wed, 29 Jul 1998, Christopher Sekiya wrote:

> 
> On Wed, 29 Jul 1998, Scott Stone wrote:
> 
> > If there's a blank line in between two entries in /etc/passwd or in
> > /etc/group, SIGSEGV.
> 
> There should _never_ be blank lines in either.  Undefined behavior
> results.
> 

Yeah, but it shouldn't sigsegv xlock.  When I had the problem with the
blank line(s), no other programs segfaulted on me.

> > If DISPLAY is not set, SIGSEGV (come on, that's so easy to trap, geez..
> > just check if XOpenDisplay returns NULL...)
> 
> Why would one run xlock without having DISPLAY set?  If you're running it
> from console, you deserve whatever you get ;)

what about if you su to root or some other user, and forget, and run
xlock? then you have a nice core sitting there.  Besides, it's still a
bug..

> 
> > At least, it affects the Xlockmore-GL package, maybe the bare-bones xlock
> > doesn't have this problem.  I'm going to try fixing it tomorrow and making
> > a new package... 
> 
> Send the diffs back to the maintainer.  Too many people just fix things
> locally.

will do.  I'll make sure I have the newest version and that it's not
already fixed, as well :)


> 
> --	Chris (wileyc@example.com)
> 
> --------------------------------------------------------------
> Next Meeting: 8 August, Tokyo Station Yaesu central gate 12:30
> featuring Linux on multiple platforms:
> i386, Sparc, PA-Risc, Amiga, SGI, Alpha, PalmPilot, ...
> Next Nomikai: 18 September, 19:30 Tengu TokyoEkiMae 03-3275-3691
> --------------------------------------------------------------
> Sponsor: PHT, makers of TurboLinux http://www.pht.co.jp
> 

--------------------------------------------------
Scott M. Stone <sstone@example.com, sstone@example.com>
               <sstone@example.com>
Linux Developer/Systems Administrator for Pacific HiTech, Inc. 
http://www.pht.com		http://armadillo.pht.co.jp
http://www.pht.co.jp	        http://www.turbolinux.com


--------------------------------------------------------------
Next Meeting: 8 August, Tokyo Station Yaesu central gate 12:30
featuring Linux on multiple platforms:
i386, Sparc, PA-Risc, Amiga, SGI, Alpha, PalmPilot, ...
Next Nomikai: 18 September, 19:30 Tengu TokyoEkiMae 03-3275-3691
--------------------------------------------------------------
Sponsor: PHT, makers of TurboLinux http://www.pht.co.jp